use domain instead of @ #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is needed, as most registrars support wildcards. |
simo981
approved these changes
Sep 17, 2021
|
I would like to see this merged as I had problems with this as well. @ulisesvina sure it's not needed, but I still think that this is a good idea to introduce in case the DNS provider does not support wildcards. |
simo981
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem inserting the spf1 entry on my DNS provider. It couldn't parse the @. Just inserting it with my domain as key worked, so I guess @ is just an alias for 'current domain'. Therefore wouldn't be using the domain instead of @ in the script be more general?