Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wildcard domains? #257

Closed
appeasementPolitik opened this issue Jan 27, 2023 · 3 comments
Closed

Add support for wildcard domains? #257

appeasementPolitik opened this issue Jan 27, 2023 · 3 comments

Comments

@appeasementPolitik
Copy link
Contributor

In my opinion this should be added, as it takes extra effort to set up a wildcard domain (extra DNS records), which I think makes it likelier that someone would also want to use it for their mail server.

If this gets the green light I can open a pull request.

@LukeSmithxyz
Copy link
Owner

What do you mean here? I mean the script doesn't set any DNS records and I assume that the A/AAAA records are already set on install.

@appeasementPolitik
Copy link
Contributor Author

appeasementPolitik commented Jan 27, 2023

Currently the script checks for a $maildomain certificate and uses it if it exists, and if it does not exist it generates a new certificate for $maildomain. I am proposing that it also checks specifically for a \*\.$domain wildcard certificate and uses it if it exists as it is also a valid certificate for $maildomain.

Not to be confused with *.$domain, which is different in regex.

@LukeSmithxyz
Copy link
Owner

Ah, I see. Good call. I've added that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants