-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gen Idea]: Simplify square root #410
Comments
I have written a working function. I added the file under the name simplify_square_roots_generator in the mathgenerator folder. Since this is the first time I am using github, please let me know if I have done something wrong, or if you need me to change something in the code. Hope the function is of use to you. |
Also, the code I have written has been modified such that the only square root simplifications it produces have neither the perfect square, nor the radical part equal to 1. Please let me know if you would like me to not incorporate that, and just produce the result without thinking about whether the number has the radical or perfect square parts equal to 1. |
Thanks, but I don't see an open pull request. I see that you have made changes on your fork. Can you open a pr with the base being the main branch of lukew3/mathgenerator and the head being the branch of your fork that you made changes on? You can find more about opening a pr here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
I agree with the way you implemented it. |
Oh. Oops. I just did that (I think?) |
Example Problem
Simplify$\sqrt{128}$ :
Example Solution
Optional, Provide Further Explanation
Given a square root that contains a perfect square multiplied by another number, remove the perfect square and leave the remaining radical.
Assign Yourself?
The text was updated successfully, but these errors were encountered: