Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallInProgressActivity.java should turn screen off onProximity #29

Closed
lukeweber opened this issue Oct 23, 2012 · 2 comments
Closed

CallInProgressActivity.java should turn screen off onProximity #29

lukeweber opened this issue Oct 23, 2012 · 2 comments

Comments

@lukeweber
Copy link
Owner

Because of the samsung galaxy ace, we don't turn the screen off. Basically, after testing a bit more, I'm pretty sure there are more phones that violate this, but I've so far only found the galaxy ace.

Instead of debasing battery life for all compliant phones, I think it's a better policy to turn off the screen in the way that works on most and not turn it off for a known non-compliant phone.

// Samsung Galaxy Ace locks if you turn the screen off.
params.screenBrightness = 0.01f;

@lukeweber
Copy link
Owner Author

We could also test whether the undocumented, but seemingly available PROXIMITY_WAKE_LOCK would work as standard and this method as a fallback.

http://stackoverflow.com/questions/3018716/android-turn-off-screen-when-close-to-face

@lukeweber
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant