Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid password message doesn't display #18

Closed
LEXUGE opened this issue Sep 14, 2022 · 1 comment · Fixed by #19
Closed

Invalid password message doesn't display #18

LEXUGE opened this issue Sep 14, 2022 · 1 comment · Fixed by #19

Comments

@LEXUGE
Copy link

LEXUGE commented Sep 14, 2022

Hi, I really like the keywind theme after all. However, there is a minor issue that it doesn't display "Invalid password: minimum length 10." correctly on registration.

I am not sure how to patch it.

@YoanSimco
Copy link
Contributor

Hi!

This is due to this line (can be fixed by removing it): https://github.com/lukin/keywind/blob/master/theme/keywind/login/register.ftl#L67.

<@inputPrimary.kw
    autocomplete="new-password"
    invalid=["password", "password-confirm"]
    message=false                             -> disable messages for this field
    name="password"
    type="password"
>
    ${msg("password")}
</@inputPrimary.kw>

I will open a pull request 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants