New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable telemetry #46
Comments
@Shatur95 yes, that makes sense. I think by creating environment variable VCPKG_DISABLE_METRICS, the telemetry would be disabled, e.g.:
If this works, all i need is to add this information to the documentation. |
Oh, yes, this will work :) |
With manifest mode it should be added to cmake runs. @lukka, could we just pass |
@Shatur yes, the action could just define the For now, this is achievable like this for uses: lukka/run-cmake@v10
with:
....
env:
VCPKG_DISABLE_METRICS: 1 Question: How would users be able to opt-in if the action always define that env var? |
Is there a user who wants to enable telemetry for CI? I don't think so :)
Totally understand. I would just pass |
Probably this would be a simple one liner solution that allow the user to opt-in, but defaults to opt-out: if (!process.env['VCPKG_ENABLE_METRICS']) process.env['VCPKG_DISABLE_METRICS'] = "1"; |
Sounds reasonable! |
On the other hand, an option would be more intuitive for the user. |
Fixed in #126 , please try |
Could you add an option to disable telemetry?
Maybe should be enabled by default? I don't think Microsoft needs statistics on vcpkg from GitHub Actions.
The text was updated successfully, but these errors were encountered: