-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag in vcpkgCommitId #47
Comments
Is it possible to add tagging support to |
@Shatur95 yes, it would be possible, no ETA though. Instead of specifying a tag, or a commit id, the best practice is to use vcpkg as a submodule, so that the vcpkg used is exactly the same locally and on CI. |
Yes, I know, but I only need vcpkg on Windows, because on Linux I need to build a package with the versions of the libraries that are in the official repository. I would even okay with #35 or #44 to have latest possible versions of the libraries. |
Please take a look to run-vcpkg@v10 and see if suites your needs. Feel free to reopen this or a new ticket about any problem you may see. |
The description still stays that a tag name as a Line 24 in 61e8552
|
@Shatur right, tags are not supported. Reopening this item. |
I guess you've never run into this issue before, but using vcpkg as a submodule is actually a terrible idea if you need to run vcpkg on windows images because of the MAX_PATH issue. There are several packages in vcpkg whose build process runs right up to the limit and only work if you use C:\VCPKG. Any base path longer than that and you'll get hard to diagnose failures and confusing error messages that take a long time to track back to their root cause. |
@justusranvier hitting the There are also other questions as well that would help in narrowing down the problem and probably delineating a solution:
|
Not all ports will result in exceeding MAX_PATH, but qtdeclarative and its dependencies will unless the base path is very short (C:\VCPKG)
From my experience the hosted runners do hit MAX_PATH. I have read there are registry hacks to turn off this limitation but they require a reboot so there's no way to use them in a hosted runner. |
Closing as more than one year of inactivity. Feel free to ask to reopen if needed. |
If I understand correctly, then
vcpkgCommitId
cannot contain a tag. But if you specify it, then I will get silently non-working cache. Workflow output with tag invcpkgCommitId
(the cache is unpacked but not used).The text was updated successfully, but these errors were encountered: