New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lsp-smart-contracts v0.10.3 #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CallumGrindle
force-pushed
the
lsp-v0.10.0
branch
6 times, most recently
from
August 11, 2023 12:02
97b8117
to
d946579
Compare
b00ste
approved these changes
Aug 11, 2023
richtera
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also tested using a patch in the test-dApp.
CallumGrindle
force-pushed
the
lsp-v0.10.0
branch
from
August 14, 2023 05:58
d946579
to
d6bbfb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Left some suggestions and questions
CallumGrindle
force-pushed
the
lsp-v0.10.0
branch
2 times, most recently
from
August 15, 2023 09:05
0074b81
to
241bf5f
Compare
CallumGrindle
force-pushed
the
lsp-v0.10.0
branch
from
August 15, 2023 09:07
241bf5f
to
2ad5660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract addresses v0.10.3