Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inline editor height variation #3333

Merged
merged 1 commit into from
May 17, 2023
Merged

fix: inline editor height variation #3333

merged 1 commit into from
May 17, 2023

Conversation

MEsteves22
Copy link
Contributor

@MEsteves22 MEsteves22 commented May 16, 2023 •
edited

  • The inline editor height was changing when the input was in edit mode or not.

Before:

Screen.Recording.2023-05-16.at.16.24.35.mov

After:

Screen.Recording.2023-05-16.at.16.25.33.mov

@MEsteves22 MEsteves22 changed the title fix: inline editor heights variation fix: inline editor height variation May 16, 2023
@github-actions github-actions bot temporarily deployed to uikit/pr-3333 May 16, 2023 15:39 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3333 May 17, 2023 10:37 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3333 May 17, 2023 11:13 Destroyed
@MEsteves22 MEsteves22 merged commit 937227b into master May 17, 2023
3 checks passed
@MEsteves22 MEsteves22 deleted the fix/inline-editor-height branch May 17, 2023 11:24
zettca pushed a commit that referenced this pull request May 29, 2023
@MEsteves22 @zettca
fix: inline editor heights variation (#3333)
0297556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zettca zettca zettca approved these changes

@plagoa plagoa plagoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MEsteves22 @zettca @plagoa