fix(VerticalNavigation): truncate text on slider navigation #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zettca
reviewed
May 19, 2023
packages/core/src/components/VerticalNavigation/NavigationSlider/NavigationSlider.styles.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/VerticalNavigation/VerticalNavigation.test.tsx
Show resolved
Hide resolved
…er/NavigationSlider.styles.tsx Co-authored-by: Bruno Henriques <zettca@gmail.com>
HQFOX
approved these changes
May 22, 2023
|
I noticed that in the "Slider mode" example the overflow tooltip is always showing when hovering the item even though the text is not truncated. |
MEsteves22
approved these changes
May 22, 2023
zettca
added a commit
that referenced
this pull request
May 29, 2023
* fix(VerticalNavigation): truncate text on slider navigation * Update packages/core/src/components/VerticalNavigation/NavigationSlider/NavigationSlider.styles.tsx Co-authored-by: Bruno Henriques <zettca@gmail.com> * fix(VerticalNavigation): truncate text on slider navigation --------- Co-authored-by: Paulo Lagoá <paulo.lagoa@@hitachivantara.com> Co-authored-by: Bruno Henriques <zettca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.