Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HvWizard, HvStepNavigation): step navigation with maxWidth on xl breakpoint. #3368 #3369

Merged
merged 1 commit into from
May 24, 2023

Conversation

stephaniegaspar
Copy link
Contributor

@stephaniegaspar stephaniegaspar commented May 24, 2023

  • HvStepNavigation: Definition of missing maxWidth on xl breakpoint
  • HvWizard: Extend definition of props maxWidth and fullWidth of HvDialog. Value lg is now default for prop maxWidth.

Copy link
Member

@zettca zettca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@zettca zettca linked an issue May 24, 2023 that may be closed by this pull request
2 tasks
@stephaniegaspar stephaniegaspar force-pushed the fix/3368 branch 2 times, most recently from 42eecd9 to 45094ed Compare May 24, 2023 17:10
…breakpoint; lumada-design#3368

* `HvStepNavigation`: Definition of missing maxWidth on `xl` breakpoint
* `HvWizard`: Extend definition of props `maxWidth` and `fullWidth` of `HvDialog`
@zettca zettca merged commit 915d176 into lumada-design:master May 24, 2023
1 of 3 checks passed
@stephaniegaspar stephaniegaspar deleted the fix/3368 branch May 26, 2023 10:48
zettca pushed a commit that referenced this pull request May 29, 2023
…breakpoint; #3368 (#3369)

* `HvStepNavigation`: Definition of missing maxWidth on `xl` breakpoint
* `HvWizard`: Extend definition of props `maxWidth` and `fullWidth` of `HvDialog`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HvStepNavigation width passes the size of HvWizard
2 participants