fix(snackbar): remove duplicated alert role #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zettca
reviewed
Jun 21, 2023
packages/core/src/components/Snackbar/SnackbarContentWrapper/SnackbarContentWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/Snackbar/SnackbarContentWrapper/SnackbarContentWrapper.tsx
Outdated
Show resolved
Hide resolved
HQFOX
force-pushed
the
HVUIKIT-6751_snackbar_role_fix
branch
from
67b5c58
to
77ff1e9
Compare
zettca
requested changes
Jun 21, 2023
HQFOX
force-pushed
the
HVUIKIT-6751_snackbar_role_fix
branch
from
4782d96
to
d7835e7
Compare
HQFOX
force-pushed
the
HVUIKIT-6751_snackbar_role_fix
branch
from
d7835e7
to
772cfcb
Compare
MEsteves22
approved these changes
Jun 22, 2023
zettca
approved these changes
Jun 22, 2023
| @@ -27,7 +42,7 @@ export interface HvNotistackSnackMessageProps { | |||
| /** Classname to apply on the root node */ | |||
| className?: string; | |||
| /** Your component tree. */ | |||
| message?: string; | |||
| message?: ReactNode | string; | |||
There was a problem hiding this comment.
this is redundant because ReactNode already includes string:
type ReactNode = string | number | boolean | ReactElement<any, string | JSXElementConstructor<any>> | Iterable<ReactNode> | ReactPortal | null | undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.