fix(DatePicker): have DatePicker use the HvFormStatus type for its status prop #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plagoa
requested review from
zettca and
MEsteves22
and removed request for
a team
zettca
reviewed
Jun 22, 2023
plagoa
force-pushed
the
chore/date_picker
branch
from
a3b465d
to
a79546a
Compare
MEsteves22
approved these changes
Jun 23, 2023
|
🚀 I would just give more height to the Variants story because we have to scroll down if we open the calendar. |
plagoa
force-pushed
the
chore/date_picker
branch
from
a79546a
to
ac3ecab
Compare
plagoa
force-pushed
the
chore/date_picker
branch
from
ac3ecab
to
8a71f95
Compare
zettca
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HvDatePickerStatustype in favor ofHvFormStatusemptyvalue for theHvDatePickerstatus as it might make sense to have it thereDatePickerstories to have a "Variants" story instead of multiple unnecessary stories for each variant