Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): styles & port to createClasses #3466

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(Button): styles & port to createClasses #3466

merged 1 commit into from
Jul 5, 2023

Conversation

zettca
Copy link
Member

@zettca zettca commented Jun 27, 2023 •
edited

  • port HvButton to createClasses util
  • fix button fontFamily
  • fix outlines showing when interacting with mouse (use focus-visible)
  • simplify/refactor styles

@zettca zettca requested a review from a team as a code owner June 27, 2023 14:44
@zettca zettca requested review from francisco-guilherme and MEsteves22 and removed request for a team June 27, 2023 14:44
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3466 June 27, 2023 16:48 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3466 June 27, 2023 16:48 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3466 June 27, 2023 18:47 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3466 June 27, 2023 18:47 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3466 June 28, 2023 10:56 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3466 June 28, 2023 10:56 Destroyed
@zettca zettca force-pushed the fix/button branch 2 times, most recently from afc6fc2 to 5b1bb30 Compare June 28, 2023 18:25
@github-actions github-actions bot temporarily deployed to uikit/pr-3466 June 28, 2023 18:43 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3466 June 28, 2023 18:43 Destroyed
@MEsteves22
Copy link
Contributor

I noticed the following for the Multi Button component:

  • The icons are missing from the "Vertical Orientation" story
  • The "Disabled" and "Disabled Item" stories are different from what we have in master (extra borders).

@zettca
Copy link
Member Author

zettca commented Jun 30, 2023 •
edited

I noticed the following for the Multi Button component:

  • The icons are missing from the "Vertical Orientation" story
  • The "Disabled" and "Disabled Item" stories are different from what we have in master (extra borders).

I've removed the content container and haven't look at the Applitools diffs yet 😐

Edit:

  • the borders were a specificity issue - reduced it
  • regarding the disappearing icons, it seems like the current HvMultiButton is making HvButton's size to be 0, because of the padding (green) (see below) - so I ended up changing it on HvMultiButton
    image

@github-actions github-actions bot temporarily deployed to uikit/pr-3466 July 3, 2023 14:57 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3466 July 3, 2023 14:57 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3466 July 4, 2023 13:50 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3466 July 4, 2023 13:50 Destroyed
@zettca zettca changed the title chore(Button): port to createClasses fix(Button): styles & port to createClasses Jul 4, 2023
@zettca
fix(Button): styles & port to createClasses
f4f38df 
- port HvButton to createClasses util
- fix button fontFamily
- fix outlines showing when interacting with mouse (use focus-visible)
- simplify/refactor styles
@github-actions github-actions bot temporarily deployed to uikit/pr-3466 July 4, 2023 18:37 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3466 July 4, 2023 18:37 Destroyed
@zettca zettca merged commit 9c8a2f6 into master Jul 5, 2023
4 of 5 checks passed
@zettca zettca deleted the fix/button branch July 5, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plagoa plagoa plagoa left review comments

@MEsteves22 MEsteves22 MEsteves22 approved these changes

@francisco-guilherme francisco-guilherme Awaiting requested review from francisco-guilherme francisco-guilherme is a code owner automatically assigned from lumada-design/imperial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zettca @MEsteves22 @plagoa