Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Container): disable gutters not working #3567

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

MEsteves22
Copy link
Contributor

@MEsteves22 MEsteves22 commented Aug 4, 2023

  • The disableGutters prop was not working. This was fixed.
  • The HvContainer component was refactored to createClasses.
  • The story was updated to apply the styles to the content.

➡️ I'll accept the changes on applitools for the container story after the PR is approved.

@MEsteves22 MEsteves22 requested a review from a team as a code owner August 4, 2023 11:33
@MEsteves22 MEsteves22 requested review from zettca and HQFOX and removed request for a team August 4, 2023 11:33
@github-actions github-actions bot temporarily deployed to uikit/pr-3567 August 4, 2023 11:52 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3567 August 4, 2023 11:52 Destroyed
@MEsteves22 MEsteves22 marked this pull request as draft August 4, 2023 11:59
@MEsteves22 MEsteves22 marked this pull request as ready for review August 4, 2023 13:33
@MEsteves22 MEsteves22 requested review from a team, plagoa and francisco-guilherme and removed request for a team August 4, 2023 13:33
@github-actions github-actions bot temporarily deployed to uikit/pr-3567 August 4, 2023 13:55 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3567 August 4, 2023 13:55 Destroyed
@MEsteves22 MEsteves22 merged commit 4cbd9c3 into master Aug 4, 2023
4 of 5 checks passed
@MEsteves22 MEsteves22 deleted the fix/HVUIKIT-6812_container branch August 4, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants