feat(defaultProps): replace theme variables with classes

[HQFOX]

I have replaced most of the theme component variables with classes to the defaultProps.
Some values I wasn't able to remove, these were mostly values used with the activeTheme ( mostly typography variants ).
Other values I left because they seemed useful to customize the component and provided some abstraction, these were mostly values that are used throughout the component in different classes or sub components.
See if you agree with the ones I left out or the ones I left in.

[MEsteves22]

Looks good 🙏

I just identified some things while reviewing.

Also, I noticed some components have two distinct areas:

• (1) one where the props are defined and used by useDefaultProps:

components: { "HvCard": { (...) }, (...) }

• (2) and one where we have some more styling and/or variants defined (and these values are mapped out to CSS vars):

card: {
     titleVariant: "label",
     subheaderVariant: "caption1",
     subheaderColor: theme.colors.secondary,
}

I believe there are still some variables in (2) that could be mapped out to (1). I identified those in my review. Also, when necessary, I also think we should map out the variables related to CSS styling by creating new classes. For example, regarding the card component, we could create a new class for the subheaderColor to remove it from (2). The only values related to CSS styling I see remaining in (2) are the header height and second level height because these seem like variables users would want to access.

Also, having variants as CSS vars is something I believe we should try to remove in this PR since these are not valid values (ex: titleVariant and subheaderVariant for the card component). Thus, I think we should review our mapping to omit them.

What of you think?

[zettca]

What a huge effort 😅 💪

Looking great overall. I still want to make a deeper review, but I'll leave these comments for now:

• I think we should separate the component improvements & missing useDefaultProps to a separate PR, to reduce the scope and size of this PR
• It would be nice if we could extract more common color keys like we did for containerBackgroundHover

[HQFOX]

I agreed with @MEsteves22 suggestion and tried removing the rest of the variables. The theme variables left are mostly button variants, colors and a few other values that weren't clear to me how to substitute, maybe we can deal with those types individually in another issue, or if you have a suggestion that I'm not seeing say so.

[MEsteves22]

👌🏻

Just noticed two small things:

[MEsteves22]

LGTM 🙏

We'll need to review the "White Labelling" page because a lot of the variables used there are no longer available. But I think we can do that in another PR.

As future work I also think that we should try to remove variants as CSS vars since these are not valid values.

[zettca]

Awesome 👌