Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: layout page and links fixed in docs #3708

Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix: layout page and links fixed in docs #3708

merged 3 commits into from
Sep 25, 2023

Conversation

MEsteves22
Copy link
Contributor

@MEsteves22 MEsteves22 commented Sep 22, 2023 •
edited

  • "Simple Grid" sample in the layout page fixed: breakpoints were undefined
  • "Packages" removed from the "Project Status" table of contents since this section doesn't exist
  • Wrong URLs fixed
  • Links fixed in the docs:
    • Anchor links to navigate to a page section were opening a new iframe
    • Links linking to other storybook pages were broken and leading to "Not found" pages

@MEsteves22 MEsteves22 requested a review from a team as a code owner September 22, 2023 17:00
@MEsteves22 MEsteves22 requested review from zettca and plagoa and removed request for a team September 22, 2023 17:00
@github-actions github-actions bot temporarily deployed to uikit/pr-3708 September 22, 2023 17:06 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3708 September 22, 2023 17:06 Destroyed
@MEsteves22 MEsteves22 marked this pull request as draft September 22, 2023 17:19
@github-actions github-actions bot temporarily deployed to uikit/pr-3708 September 25, 2023 08:11 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3708 September 25, 2023 08:11 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3708 September 25, 2023 08:46 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3708 September 25, 2023 08:46 Destroyed
@MEsteves22 MEsteves22 marked this pull request as ready for review September 25, 2023 08:56
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3708 September 25, 2023 09:00 Destroyed
zettca
zettca approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@zettca zettca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Maybe we should consider using Storybook's LinkTo component.
The syntax isn't as nice as []() and adds more coupling to Storybook, but it's more future-proof and the navigation is smoother.

But for now, this is great 👍

@MEsteves22 MEsteves22 merged commit 9e1784b into master Sep 25, 2023
5 checks passed
@MEsteves22 MEsteves22 deleted the docs/random-fixes branch September 25, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zettca zettca zettca approved these changes

@plagoa plagoa Awaiting requested review from plagoa plagoa is a code owner automatically assigned from lumada-design/imperial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MEsteves22 @zettca