fix(Flow): prevent drag and zoom on nodes #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEsteves22
requested review from
plagoa and
francisco-guilherme
and removed request for
a team
plagoa
approved these changes
Nov 10, 2023
zettca
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fixes were implemented:
nodragclass added to the text and select params to prevent dragging the node within the fields: because of this it wasn't possible to select the text inside the input for example.nowheelclass added to the base node to disable the default canvas pan behaviour when scrolling inside the node: without this the canvas was zooming in or out when scrolling inside the node.maxHeightadded to the select param to avoid having huge list.This can be tested with the "Tron" node inside the "Main" sample.