fix(DropdownMenu): add variant prop to be inline with other components #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HQFOX
requested review from
zettca and
MEsteves22
and removed request for
a team
zettca
approved these changes
Jan 29, 2024
MEsteves22
requested changes
Jan 30, 2024
| @@ -80,6 +85,7 @@ export const HvDropDownMenu = (props: HvDropDownMenuProps) => { | |||
| expanded, | |||
| defaultExpanded = false, | |||
| category = "secondaryGhost", | |||
| variant = "secondaryGhost", | |||
There was a problem hiding this comment.
If the user doesn't use the new variant property and they are still using category, the default value for the variant property will always override the value set for category. I believe not setting a default value for variant should fix this for now (in a next major we'll add the default value again).
HQFOX
force-pushed
the
fix/dropdown_menu_variants
branch
from
0b4e823
to
54da6d5
Compare
MEsteves22
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make much sense that this component has a prop categories while others have variants and the values are the same.
category was marked as deprecated and not remove to not cause breaking changes