feat(ListItem): improve reusability with external focus management #4006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zettca
requested review from
VGervasio and
MEsteves22
and removed request for
a team
zettca
force-pushed
the
feat/select
branch
2 times, most recently
from
816eaa6
to
f07e901
Compare
changes related to reusing these components in `HvSelect`
- forwardRef `HvPanel`
- use `HvPanel` in List stories
- improve `HvListItem` reusability with external focus management
- allow `tabIndex` to be used
- allow `aria-disabled` & `aria-selected` to dictate disable/selection
state
MEsteves22
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes related to reusing these components in
HvSelect:HvPanelHvPanelin List storiesHvListItemreusability with external focus managementtabIndexto be usedaria-disabled&aria-selectedto dictate disable/selection state