feat(ScrollTo): use fulls URLs, allow replace and render anchor links #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nantunes
requested review from
zettca and
VGervasio
and removed request for
a team
MEsteves22
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
LGTM 🙏
I just had the following questions/doubts while reviewing:
- The scroll item default role changed from
buttontolink. I think this can be considered a breaking change. However, this change/fix makes sense to me sincehrefdefaults totrue. Was this intentional? relativeLinksdefaults tofalsebut I believe that to maintain the previous behaviour it should default totrue. Can this change lead to any breaking change to the users that I'm not seeing?
zettca
reviewed
Feb 15, 2024
packages/core/src/ScrollTo/Horizontal/HorizontalScrollListItem/HorizontalScrollListItem.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/ScrollTo/Horizontal/HorizontalScrollListItem/HorizontalScrollListItem.tsx
Outdated
Show resolved
Hide resolved
…d render anchor links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.