Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info on file uploader in storybook. #4091

Open
2 tasks done
VitaliiSemchyshyn opened this issue Mar 19, 2024 · 1 comment
Open
2 tasks done

Add more info on file uploader in storybook. #4091

VitaliiSemchyshyn opened this issue Mar 19, 2024 · 1 comment
Labels
➕ enhancement An enhancement to an existing feature

Comments

@VitaliiSemchyshyn
Copy link

VitaliiSemchyshyn commented Mar 19, 2024

Latest version

  • I have tested the latest version

No Hitachi confidential content

  • I'm not including any Hitachi confidential content

Summary 💡

I want to use HvFileUploader, but the storybooks miss some info on how to use it.
What I want to know is how can I customize files preview (the list under the uploading area with selected files).
I also don't see what is HvFileUploaderPreview and how to use it.
For example - how can I display some kind of error that happened during uploading on the server, like on the screenshot?
Or how to inform user that file is uploaded successfully? Such use cases would be very welcome in the storybook.
image

Examples 🌈

No response

Motivation 🔦

No response

@VitaliiSemchyshyn VitaliiSemchyshyn added the ⌛ needs triage Waiting for a review. These issues haven't been looked at yet by a maintainer. label Mar 19, 2024
@zettca zettca added ➕ enhancement An enhancement to an existing feature and removed ⌛ needs triage Waiting for a review. These issues haven't been looked at yet by a maintainer. labels Apr 2, 2024
@zettca
Copy link
Member

zettca commented Apr 2, 2024

Hey @VitaliiSemchyshyn 👋

Thanks for the feedback. We'll be reviewing the File Uploader docs to address some of those use-cases

In the meantime, feel free to take a look at the source-code of our samples, as the "Show code" in Storybook isn't great:
https://github.com/lumada-design/hv-uikit-react/blob/master/packages/core/src/FileUploader/FileUploader.stories.tsx#L195-L209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ enhancement An enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants