Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensions on Nunjucks #108

Merged
merged 2 commits into from Jun 21, 2021
Merged

Conversation

fserb
Copy link
Contributor

@fserb fserb commented Jun 21, 2021

Extensions on Nunjucks can't be passed by regular options, they need to be added by addExtension, so we add a new extensions option and register them.

I had to move it inside the passed options, because options.extensions is already a thing. We could do options.nunjucks_extensions if you want it to be outside options.options. WDYT?

@oscarotero
Copy link
Member

Great, thanks for this.
For naming consistency with postcss and markdown, I'd use plugins as the name for this option.

@fserb
Copy link
Contributor Author

fserb commented Jun 21, 2021

Done. Also moved to top level options, as the other plugins do.

@oscarotero oscarotero merged commit 70ad915 into lumeland:master Jun 21, 2021
@oscarotero
Copy link
Member

Thanks! 👍

@fserb fserb deleted the nunjucks-extension branch June 21, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants