Allow passing sourceMap options to PostCSS #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostCSS accepts `boolean | SourceMapOptions` as `options.map`.
This slightly changes the default behavior, as "map: true" will default to inline.
We can change it to `options.sourceMap === true ? {inline: false} : options.sourceMap`, but I'm not sure is worth keeping the extra weirdness. WDYT?
|
Mmmm, ok, it makes sense. |
|
like this? |
|
Yes, but no need to replicate the types in the dep file. Postcss provides the types here: https://deno.land/x/postcss@8.3.11/lib/postcss.d.ts#L258 |
|
I have no idea if this is the proper way to lift a definition from a d.ts. :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostCSS accepts
boolean | SourceMapOptionsasoptions.map.This slightly changes the default behavior, as "map: true" will default to inline.
We can change it to
options.sourceMap === true ? {inline: false} : options.sourceMap, but I'm not sure is worth keeping the extra weirdness. WDYT?