Add support for deno.jsonc
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Aug 7, 2022
oscarotero
requested changes
Aug 7, 2022
|
Ok, the solution of showing the required changes but not apply them looks good. |
kidonng
commented
Aug 8, 2022
oscarotero
reviewed
Aug 8, 2022
|
|
||
| console.log(brightGreen("Deno configuration file saved:"), "deno.json"); | ||
| if (await exists("deno.jsonc")) { | ||
| promptConfigUpdate({ importMap: config.importMap, tasks: config.tasks }); |
There was a problem hiding this comment.
It would be nice to show the deno.jsonc warning only if there's something to change. Most of the time, the upgrade or import-map commands only update the import_map.json file.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #211
See #209 (comment)
This is how it currently looks when calling
lume import-mapwithdeno.jsonc, not sure if this is the best approach: