Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split core functionality in mod.ts #535

Closed
scarf005 opened this issue Dec 22, 2023 · 2 comments · Fixed by #540
Closed

Split core functionality in mod.ts #535

scarf005 opened this issue Dec 22, 2023 · 2 comments · Fixed by #540
Labels
enhancement New feature or request

Comments

@scarf005
Copy link
Contributor

scarf005 commented Dec 22, 2023 •
edited
Loading

Enter your suggestions in details:

currently many features are packed into lume/mod.ts.

  1. getOptionsFromCli is private.
  2. lume uses predefined plugins.
  3. ignorelist is private inside function body,

it may be beneficial to extract these features into separate files. for example, it would make creating an lightweight lume function without pre-defined modules (url, json, vento, etc...) with Cli support easier.
@scarf005 scarf005 added the enhancement New feature or request label Dec 22, 2023
@oscarotero
Copy link
Member

I guess getOptionsFromCli() can be moved to core/utils/ folder. What do you think?
Do you want to work on a PR?

@scarf005
Copy link
Contributor Author

yes, i'll open a PR.

@scarf005 scarf005 mentioned this issue Dec 24, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: extract getOptionsFromCli scarf005/lume
2 participants
@oscarotero @scarf005