Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch changed models #68

Open
nandaloo opened this issue Sep 19, 2019 · 2 comments
Open

watch changed models #68

nandaloo opened this issue Sep 19, 2019 · 2 comments
Assignees

Comments

@nandaloo
Copy link
Member

A modelbase has the ability to watch for changes in its model directory. Currently it only reacts on new models in the directoy, but does not reload existing models if they are changed.
@jong42 requested this feature. Please discuss if this is a desired feature or not, and - if desired - implement it.

@nandaloo
Copy link
Member Author

Con:
I am unsure this is a good way to support the incremental workflow of bayesian modelling with ppls. The reason is that overwriting a model makes it impossible to compare the new (incrementally changed) model with the old one.

Pro:
It seems the natural thing to do, and the above bayseian modelling is a very specific use case.

Conclusion:
I believe the feature should be implemented, but maybe we need some way of 'auotmatically' name incrementally changed models for the ppls use case?

@jong42
Copy link
Collaborator

jong42 commented Sep 20, 2019

I also think it should be implemented. We don't loose any functionality: Comparing models is still possible by just naming them differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants