Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building example fails with unresolved dlmalloc import #394

Closed
blambillotte opened this issue Feb 28, 2020 · 7 comments
Closed

Building example fails with unresolved dlmalloc import #394

blambillotte opened this issue Feb 28, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@blambillotte
Copy link

Attempting to wasm-pack build the interpreter-in-browser example errors with the current rust nightly. It appears core::alloc::Alloc no longer exists?

Error:

error[E0432]: unresolved import `core::alloc::Alloc`
  --> /Users/ben/.cargo/registry/src/github.com-1ecc6299db9ec823/dlmalloc-0.1.3/src/lib.rs:21:19
   |
21 | use core::alloc::{Alloc, Layout, AllocErr};
   |                   ^^^^^ no `Alloc` in `alloc`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `dlmalloc`.

Falling back to an older rust nightly seemed to resolve this rustup install nightly-2020-01-02 -> rustup default nightly-2020-01-02

Very new to Rust so apologies if I'm missing something fundamental.

@KronicDeth
Copy link
Collaborator

It's possible I'm still back in December:

rustc --version
rustc 1.41.0-nightly (19bd93467 2019-12-18)

I'll update to latest and update anything that needs to be fixed.

@KronicDeth KronicDeth added the bug Something isn't working label Feb 28, 2020
@KronicDeth KronicDeth self-assigned this Feb 28, 2020
@KronicDeth
Copy link
Collaborator

I can reproduce after updating

rustc --version
rustc 1.43.0-nightly (6d69caba1 2020-02-27)

@KronicDeth
Copy link
Collaborator

@KronicDeth
Copy link
Collaborator

This is going to take a bit. @hansihe bumpalo needs to updated for compatibility too.

@hansihe
Copy link
Collaborator

hansihe commented Feb 29, 2020

For the eir parts, this is actually mostly done already locally. I'll try to get things cleaned up and pushed tomorrow

@KronicDeth
Copy link
Collaborator

Since the macOS build doesn't pin the rust version, all macOS builds are broke like (https://github.com/lumen/lumen/pull/395/checks?check_run_id=478804604).

@bitwalker
Copy link
Collaborator

Closing, as this should no longer be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants