Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nix dev environment #98

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add Nix dev environment #98

merged 2 commits into from
Oct 25, 2023

Conversation

sectore
Copy link
Contributor

@sectore sectore commented Oct 24, 2023

Some notes in the README.

Question: Have you changed the default theme recently? Got a black theme by building v1.2.7 before, but now it's gone.

Screen shot:

screenshot-main

Side-note: It's recommended to keep main branch clean. Avoid pushing WIP or broken stuff in there, but create draft PRs for it. It's hard to follow and might not work for others. That's why this PR is on top on 0de72eb , but not on latest main (which I could not run properly).

@reyamir
Copy link
Collaborator

reyamir commented Oct 24, 2023

Hi, thank for your contribution
Yes, main branch is a bit dirty now, this is my first open source project, I don't know how to manage git correctly 😅

But after v2 release in this Thursday, I will try keep it clean and doing semver correctly

@reyamir
Copy link
Collaborator

reyamir commented Oct 24, 2023

And in v2, I've redesign overal UI/UX which support light and dark mode (in future it will have multi-theme too)

@reyamir
Copy link
Collaborator

reyamir commented Oct 24, 2023

I'm not familar with Nix, but I will setup it in tomorrow and test your PR then I will merge it

@reyamir reyamir merged commit 50f81a7 into lumehq:main Oct 25, 2023
@sectore sectore deleted the feat/flake-nix branch October 25, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants