New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests to centralise the test main for CI #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see what's the point of making a new package for tests?
It makes it easy for the other packages to depend on the centralised common main for running tests in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing it, good to see it refactored!
core/test/spec/Main.hs
Outdated
import System.Directory (createDirectoryIfMissing) | ||
import System.Environment (lookupEnv) | ||
import System.FilePath ((</>)) | ||
import Luna.CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tend to use qualified imports everywhere. I'd rather use it like:
import qualified Luna.CI as CI
...
main = CI.main Spec.spec
No description provided.