Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choices hidden by dialogue box #34

Closed
seleb opened this issue Oct 30, 2021 · 0 comments · Fixed by #40
Closed

Choices hidden by dialogue box #34

seleb opened this issue Oct 30, 2021 · 0 comments · Fixed by #40

Comments

@seleb
Copy link
Contributor

seleb commented Oct 30, 2021

If you have a lot of options for a single choice and include a line of dialogue, they can get hidden by the dialogue box. The covered-up choices are still clickable, but should probably always be on top of dialogue.

Note that there's a similar issue with choices overflowing the top/bottom of the screen if you add so many that they can't fit vertically. Hopefully folks aren't putting that many options on a single choice ofc, but you could support arbitrarily long choice lists with scrolling or pagination.
seleb added a commit to seleb/RenJS-V2 that referenced this issue Oct 30, 2021
@seleb
fix: interactive elements rendered underneath dialogue
a3e78f7 
fixes lunafromthemoon#34

The order of HUD elements is currently defined by the GUI config, which results in choices being rendered underneath dialogue if both are on screen. This adds a sort to the GUI config before the elements are created to help avoid overlap issues.
@seleb seleb mentioned this issue Oct 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: interactive elements rendered underneath dialogue seleb/RenJS-V2
1 participant
@seleb