Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set a link that errors as pending #21

Open
lunakv opened this issue Feb 3, 2023 · 1 comment
Open

Don't set a link that errors as pending #21

lunakv opened this issue Feb 3, 2023 · 1 comment
Labels
admin This issue doesn't affect regular users, only administrators. bug Something isn't working good first issue Good for newcomers

Comments

@lunakv
Copy link
Owner

lunakv commented Feb 3, 2023

Sometimes WotC messes up their update process, and things happen. For example, a new CR is released but the TXT link returns 404.

To avoid having to manually check/reset the pending links, we should make a basic check that the parsed link at least returns an actual response before saving it.

@lunakv lunakv added bug Something isn't working good first issue Good for newcomers labels Feb 3, 2023
@lunakv
Copy link
Owner Author

lunakv commented Feb 4, 2023

Encountering this condition (an erroring link) should probably still create a notification though? There's also a discussion to be had about how to handle the situation when a link that's already pending changes again.

@lunakv lunakv added the admin This issue doesn't affect regular users, only administrators. label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin This issue doesn't affect regular users, only administrators. bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant