Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back up database data #48

Open
lunakv opened this issue Jun 13, 2023 · 2 comments
Open

Back up database data #48

lunakv opened this issue Jun 13, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers infrastructure May need updates outside of application code
Milestone

Comments

@lunakv
Copy link
Owner

lunakv commented Jun 13, 2023

The backups currently only contain the source files. It would be good to have some database dumps included for parsed data as well, so it doesn't get lost in case the databse is corrupted or something.

The approach that comes to mind for this is one file per table with all the metadata columns, and then a directory with JSONs for each row with data columns.

@lunakv lunakv added enhancement New feature or request infrastructure May need updates outside of application code good first issue Good for newcomers labels Jun 13, 2023
@lunakv lunakv added this to the v0.4 milestone Jun 14, 2023
@KingSupernova31
Copy link

Isn't it easy to regenerate from the source data?

@lunakv
Copy link
Owner Author

lunakv commented Jun 14, 2023

The parsed documents, yes, those are trivial to recreate. The diffs, however, contain a lot of manual tweaks that I really wouldn't want to spend the time on re-adjusting. And once we're storing those, we might as well store it all.

Not to mention, the database also contains metadata such as set names, set codes, and update bulletin links, which don't appear in the raw files.

@lunakv lunakv modified the milestones: v0.4, v0.5 Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers infrastructure May need updates outside of application code
Projects
None yet
Development

No branches or pull requests

2 participants