Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better way of detecting keyword rules #49

Open
lunakv opened this issue Jun 13, 2023 · 0 comments
Open

Find better way of detecting keyword rules #49

lunakv opened this issue Jun 13, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers low priority Things to do when everything else is working

Comments

@lunakv
Copy link
Owner

lunakv commented Jun 13, 2023

The extractor determines whether a rule is defining a keyword / keyword action / ability word purely by the rule number (or rule section of that number). In the (admittedly fairly unlikely) event that either 701, 702, or 207.2c ever move, all of this breaks down. Therefore we should figure out a more robust way of detecting these rules.

The ability word list could be found based on some known text in the rule. This also isn't foolproof, but might be less likely to change if done properly. Once #27 is implemented, keywords and keyword actions can be found based on their ToC entries (I doubt they're going to rename the "Keywords" section).

@lunakv lunakv added enhancement New feature or request low priority Things to do when everything else is working labels Jun 13, 2023
@lunakv lunakv added the good first issue Good for newcomers label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers low priority Things to do when everything else is working
Projects
None yet
Development

No branches or pull requests

1 participant