Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icon/Image command fails when no folder is opened #107

Closed
MikeTheGreat opened this issue Nov 18, 2021 · 6 comments
Closed

New Icon/Image command fails when no folder is opened #107

MikeTheGreat opened this issue Nov 18, 2021 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@MikeTheGreat
Copy link

Thank you for creating this free, open source image editor for VSCode!

I'm on Windows 10, and having just installed Luna Paint into VSCode when I run the New Icon command (via the command palette) it asks me for the width & height ( I go with the default 256x256) and then I get the following error:

image

This seems not great so I figured I'd let y'all know.

I confirmed that the directory does exist.
It's weird that the error message is talking about a relative path but the listed path is absolute (starts with C:).

@Tyriar
Copy link
Member

Tyriar commented Nov 18, 2021

Hmm I've never seen this and can't reproduce, can you give some more details about what type of window you're running this in? A gif of the whole window with the explorer showing would probably give me enough information.

@Tyriar
Copy link
Member

Tyriar commented Nov 18, 2021

Oh I can reproduce, it happens when opening in a window without a folder opened.

@Tyriar Tyriar added bug Something isn't working and removed needs more info labels Nov 18, 2021
@Tyriar Tyriar added this to the 0.11.0 milestone Nov 18, 2021
@onmax
Copy link

onmax commented Nov 18, 2021

Oh I can reproduce, it happens when opening in a window without a folder opened.

It happens the same to me, but trying to create an image instead of an icon

@Tyriar Tyriar changed the title New Icon command fails on Windows 10 New Icon/Image command fails when no folder is opened Nov 18, 2021
@Tyriar
Copy link
Member

Tyriar commented Nov 19, 2021

Looks like this is a regression in VS Code, will report soon

@Tyriar
Copy link
Member

Tyriar commented Nov 19, 2021

Reported to microsoft/vscode#137524, nothing to do here after reviewing the code.

@Tyriar Tyriar closed this as completed Nov 19, 2021
@Tyriar Tyriar removed this from the 0.11.0 milestone Nov 19, 2021
@Tyriar Tyriar added upstream This issue is due to a problem in VS Code and removed bug Something isn't working labels Nov 19, 2021
@Tyriar
Copy link
Member

Tyriar commented Nov 20, 2021

This actually is an issue with a misuse of Uri.parse, reopening

@Tyriar Tyriar reopened this Nov 20, 2021
@Tyriar Tyriar added bug Something isn't working and removed upstream This issue is due to a problem in VS Code labels Nov 20, 2021
@Tyriar Tyriar added this to the 0.11.0 milestone Nov 20, 2021
@Tyriar Tyriar closed this as completed Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants