Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open an image immediately in the edit mode #136

Closed
MatejBransky opened this issue Mar 24, 2022 · 6 comments
Closed

Don't open an image immediately in the edit mode #136

MatejBransky opened this issue Mar 24, 2022 · 6 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@MatejBransky
Copy link

Hi, thanks for your extension but I don't know how to use it for simple browsing because I don't want to edit an image immediately. I would like to do it maybe later but before that I need to browse which I want to edit and with immediately enabled edit mode a lot of panels are there which hides huge parts of the image so it's easier for me to open this image in a file explorer, to see it there and then maybe go back to VS Code to edit it and that's just annoying.

Or is it possible to use it with some other extension which just shows images and then open it in this extension?

Thank you for your response.

@MatejBransky MatejBransky changed the title Open file in firstly in a view mode and then enable edit mode Don't open an image immediately in the edit mode Mar 24, 2022
@Tyriar
Copy link
Member

Tyriar commented Mar 24, 2022

It sounds like you're the type of user that would want to keep the default image preview extension as the default and then reopen the image with. VS Code may at some point allow an edit button to be added to the image preview (microsoft/vscode#116120), but for now the way to do this would be to clear out luna.editor from your workbench.editorAssociations setting, opening an image should then show this:

image

Select configure and then Image Preview:

image

Images should now open in the image preview and to "upgrade" to Luna Paint you would need to run the View: Reopen Editor With command. If this is a common thing you could also create a custom keybinding for workbench.action.reopenWithEditor like this:

{
  "key": "ctrl+k b",
  "command": "workbench.action.reopenWithEditor"
}

@Tyriar Tyriar closed this as completed Mar 24, 2022
@Tyriar Tyriar added the question Further information is requested label Mar 24, 2022
@MatejBransky
Copy link
Author

That's a clever solution! Thank you. 🙂

@Tyriar
Copy link
Member

Tyriar commented Mar 24, 2022

Will reopen to track adding this to https://github.com/lunapaint/vscode-luna-paint/wiki/Customization as it's not very obvious 🙂

@Tyriar Tyriar reopened this Mar 24, 2022
@Tyriar Tyriar added this to the 0.14.0 milestone Mar 24, 2022
@Tyriar Tyriar added documentation Improvements or additions to documentation and removed question Further information is requested labels Mar 24, 2022
@Tyriar
Copy link
Member

Tyriar commented May 7, 2022

@Tyriar Tyriar closed this as completed May 7, 2022
@enricodias
Copy link

The popup asking to keep Luna as the default will show only once. After that, even if you didn't pick any option Luna will keep being the default even without any workbench.editorAssociations setting present.

Restarting vscode or reinstalling the extension didn't work.

@Tyriar
Copy link
Member

Tyriar commented Nov 23, 2022

@enricodias if that's so it's a bug in VS Code, could you report to https://github.com/microsoft/vscode/issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants