Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockspec practices #70

Closed
daurnimator opened this issue Nov 7, 2012 · 4 comments
Closed

rockspec practices #70

daurnimator opened this issue Nov 7, 2012 · 4 comments

Comments

@daurnimator
Copy link
Contributor

I'm thinking the rockspec in the repository should point to the repository itself.

version = "HEAD-0"
source = {
  url = "git://github.com/daurnimator/busted.git" ;
}

file needs to be renamed to busted-HEAD-0.rockspec

Adding a version or static download should only be done on release.

@ajacksified
Copy link
Contributor

'luarocks make' will make and install the local source, and ignore the rockspec source directive; what benefit does that give us?

@daurnimator
Copy link
Contributor Author

It will? I recall trying and it would just download the one in the rockspec...

@DorianGray
Copy link
Contributor

No, it builds the rockspec from the current directory. We use it for testing all the time.

@daurnimator
Copy link
Contributor Author

Ah, sorry.
I was to do luarocks install busted.spec
luarocks make works fine :)

I still think keeping a specific version rockspec in the repository is strange though..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants