Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibreSSL compatibility #29

Closed
VanNostrand opened this issue Jan 1, 2015 · 4 comments
Closed

LibreSSL compatibility #29

VanNostrand opened this issue Jan 1, 2015 · 4 comments

Comments

@VanNostrand
Copy link

Hi, this compile error happens when compiling against libressl:

ssl.c: In function 'meth_compression':
ssl.c:404:3: error: unknown type name 'COMP_METHOD'
   const COMP_METHOD *comp;
   ^
<builtin>: recipe for target 'ssl.o' failed
@daurnimator
Copy link
Contributor

COMP_METHOD still exists in libressl: https://github.com/libressl-portable/openbsd/blob/master/src/lib/libssl/src/crypto/comp/comp.h

Maybe some extra header needs to be included?

@VanNostrand
Copy link
Author

libressl has this typedef in include/openssl/comp.h; the sources compile with libressl if #include <openssl/comp.h> is added to ssl.c

@sortie
Copy link

sortie commented Jan 2, 2015

Compression support was removed from LibreSSL. The inclusion of <openssl/comp.h> from <openssl/ssl.h> was removed in the http://freshbsd.org/commit/openbsd/b13dbd20ab3f5c4544ee24eeb184ab912dd9808a?diff=lib%2Flibssl%2Fsrc%2Fssl%2Fssl.h change. On LibreSSL, meth_compression should just unconditonally return no compression is being used. (Or the interface could be removed?) LibreSSL unconditonally defines OPENSSL_NO_COMP to signal it has no compression support. You could use that macro to control whether the compression interfaces are used.

@brunoos
Copy link
Member

brunoos commented Jan 28, 2015

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants