Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Unix Socket for Windows #328

Open
MikuAuahDark opened this issue Apr 30, 2021 · 2 comments · May be fixed by #396
Open

Enabling Unix Socket for Windows #328

MikuAuahDark opened this issue Apr 30, 2021 · 2 comments · May be fixed by #396

Comments

@MikuAuahDark
Copy link

Is it possible to enable codepath that allows Unix Socket to be created for Windows platforms? Recent Windows 10 supports Unix socket.

@MikuAuahDark
Copy link
Author

It's been more than a year and I don't hear any response, so might as well bump this one and share my findings.

So in one of our project, we recently updating to LuaSocket 3.1.0, so I took the opportunity to enable Unix sockets in Windows. It seems enabling this support is a matter of changing the included file. In Windows, #include <afunix.h> is used instead of #include <sys/un.h>. love2d/love@857cf40.

Quick test of the Unix stream socket and it behaves as expected. Unfortunately Unix datagram is not supported.

Unix sockets in Windows has been supported since Windows 10 1809. Would there be an plan to enable unix sockets in Windows?

@alerque
Copy link
Member

alerque commented Oct 11, 2022

We'd be happy to facilitate any PRs contributing to a better experience on the Windows side of things. Neither I nor any other current maintainer actively uses Windows though so researching, coding, and testing for this will need to come from community contributions. When you first posted this there wasn't an active maintainer, but I think we've made some progress on that front and there should be a path for improvements to integrated and released if they are contributed and tested.

@MikuAuahDark MikuAuahDark linked a pull request Dec 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants