Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dir.makepath() errors when using a UNC path #12

Closed
rjpcomputing opened this issue Jun 7, 2011 · 3 comments
Closed

dir.makepath() errors when using a UNC path #12

rjpcomputing opened this issue Jun 7, 2011 · 3 comments

Comments

@rjpcomputing
Copy link
Contributor

dir.makepath() errors when using a UNC path (e.g. \share\some_dir\another\path)

Error:

...\Lua\5.1\lua\pl\dir.lua:311: attempt to index local 'p' (a nil value)
@stevedonovan
Copy link
Contributor

On Tue, Jun 7, 2011 at 7:41 PM, rjpcomputing
reply@reply.github.com
wrote:

dir.makepath() errors when using a UNC path (e.g. \share\some_dir\another\path)

I agree that it should not crash, but what should it do, apart from
returning an error value? The Python os.path module actually has a
number of extra functions specifically tailored to UNC paths which are
probably worth emulating.

I've done a little test with the local Novel shares and yes, I think
the standard functions should work...

steve d.

@rjpcomputing
Copy link
Contributor Author

I think the standard file operations all work with them, under Windows. There really is not support in Linux that I know of. So, I think you should allow them and not mess with the path because it starts with \.

Can that be done?

@stevedonovan
Copy link
Contributor

On Fri, Jun 10, 2011 at 7:19 PM, rjpcomputing <reply+i-1017994->

Can that be done?

The changes I pushed up yesterday work for me, although I was using
Novell shares.

path.abspath() needed to be taught about '' paths and not put a
drive letter in front of them.

So yes, it should work!

Doc errors also sorted out.

steve d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants