Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick down remaining kills on each mission. #20

Open
joncage opened this issue Apr 22, 2021 · 8 comments
Open

Tick down remaining kills on each mission. #20

joncage opened this issue Apr 22, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@joncage
Copy link

joncage commented Apr 22, 2021

Would be neater to tick down the kills for each mission as you kill pirates.

Not easy but maybe if you know the target faction and the time the mission was accepted, you could tick them off one by one.

@lunarplasma
Copy link
Owner

Yeah, I had considered doing it as an estimate. Maybe even make it so that it's a textbox that the user can manually correct if they so wished.

@lunarplasma lunarplasma added the enhancement New feature or request label Apr 23, 2021
@Sebyujii
Copy link

I'm not too sure about the implementation but I wouldnt recommend checking the currently targeted ships and count +1 whenever I retarget another pirate. Most of the time I would start attacking all pirates of a wing and afterwards kill them one by one. With the thought above, that could maybe count every pirate two times.

@joncage
Copy link
Author

joncage commented Apr 23, 2021

I was thinking each time a bounty is paid (caveat; I've not checked the logs to see how feasible this is), use that to tick down the number.

Doing it when you target a pirate wouldn't be enough I don't think - lots of ways that could go wrong.

@Sebyujii
Copy link

yeah problem being, you probably are not only killing mission targets in res, right?

@jberanek
Copy link
Contributor

Well, an example journal entry:

{ "timestamp":"2021-04-21T18:24:46Z", "event":"Bounty", "Rewards":[ { "Faction":"LHS 1358 Fortune Group", "Reward":70245 } ], "Target":"federation_dropship", "Target_Localised":"Federal Dropship", "TotalReward":70245, "VictimFaction":"LHS 1358 Jet Gang", "SharedWithOthers":2 }

@jberanek
Copy link
Contributor

However, you don't know which mission(s) that will apply to.

@lunarplasma
Copy link
Owner

lunarplasma commented Apr 23, 2021

However, you don't know which mission(s) that will apply to.

It should apply to each top mission on the stack for that faction - ie. the oldest ones.

Yeah, that bounty event looks promising.

@joncage
Copy link
Author

joncage commented Apr 23, 2021

It should apply to each top mission on the stack for that faction - ie. the oldest ones.

That was my thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants