Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): specify required powershell version for the installation script #2376

Merged
merged 1 commit into from Mar 25, 2022

Conversation

ahsan-a
Copy link
Contributor

@ahsan-a ahsan-a commented Mar 20, 2022

Description

The default version of PowerShell installed on most people's computers is v5, however the script only works on v7+. It would be good to have some indicator of this in the readme. I edited the readme and included a link on how to install too.

@abzcoding abzcoding requested a review from kylo252 March 21, 2022 18:48
@kylo252
Copy link
Collaborator

kylo252 commented Mar 23, 2022

@ahsan-a, thank you so much!

you can see the log from commit-lint here, https://github.com/LunarVim/LunarVim/actions/runs/2012863763
you can use fix(windows): specify pwsh version instead as the commit title/subject

$ git commit --amend

@kylo252 kylo252 changed the title [Doc] specify powershell version needed for installation script fix(windows): specify required powershell version for the installation script Mar 23, 2022
@kylo252 kylo252 force-pushed the patch-1 branch 2 times, most recently from 82f57ac to 68ea1a5 Compare March 25, 2022 14:16
The default version of PowerShell installed on most people's computers is v5, but v7+ is required.
It would be good to have some indicator of this in the readme.
@kylo252 kylo252 merged commit 36c836d into LunarVim:rolling Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants