fix(installer/pwsh): fixes some details on installer and uninstaller #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerra08
force-pushed
the
fix/pwsh-installer
branch
from
3444c3b
to
9d94e9f
Compare
|
Updated commit message |
guerra08
force-pushed
the
fix/pwsh-installer
branch
from
9d94e9f
to
b45ac21
Compare
@kylo252 Needed to remove upper case on subject, sorry |
kylo252
approved these changes
Apr 2, 2022
kylo252
changed the title
Happy to help! |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes and issue that prevents a new line to be correctly added on the Powershell
$Profilefile to set the lvim alias.This also fixes and issue that prevents the execution of the
uninstall.ps1script. It was lacking the call to themainfunction. It also fixes some issues when trying to parse the cli args, and also when trying to test some of the old folders to be removed.Test process
This was tested on a local install of LunarVim, in a Windows 11 machine with the latest version of Powershell installed.