Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update deprecated methods in example configuration for trouble.nvim #2416

Merged
merged 2 commits into from Apr 2, 2022
Merged

fix: update deprecated methods in example configuration for trouble.nvim #2416

merged 2 commits into from Apr 2, 2022

Conversation

juanlopez4691
Copy link
Contributor

Description

Fixes warnings caused by the use of lsp deprecated diagnostics methods, for document and workspace:

  • lsp_document_diagnostics
  • lsp_workspace_diagnostics

How Has This Been Tested?

Warnings are displayed if trouble document diagnostics and trouble workspace diagnostics keyboard mappings suggested in the config.example.lua or config_win.example.lua are used.

Screenshot 2022-04-02 at 11 12 14

Screenshot 2022-04-02 at 11 07 53

kylo252
kylo252 requested changes Apr 2, 2022
View reviewed changes
Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the confusion earlier, I thought these were telescope mappings :)

utils/installer/config.example.lua Outdated Show resolved Hide resolved
utils/installer/config_win.example.lua Outdated Show resolved Hide resolved
@kylo252 kylo252 changed the title [Bugfix]: lsp deprecated methods were suggested in config example. fix: update deprecated methods in example configuration for trouble.nvim Apr 2, 2022
@kylo252
Copy link
Collaborator

kylo252 commented Apr 2, 2022

@juanlopez4691, please rebase on rolling again to get rid of the CI error, sorry about that!

@juanlopez4691
Copy link
Contributor Author

@juanlopez4691, please rebase on rolling again to get rid of the CI error, sorry about that!

No problem, done 👍

@kylo252 kylo252 merged commit 8a7bd81 into LunarVim:rolling Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylo252 kylo252 kylo252 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juanlopez4691 @kylo252