fix(autocmds): toggle format-on-save properly #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! I think I originally wanted to delete the augroup itself, but that solution was flakey because I was getting errors about it still being in-use. |
|
Should I fix the commit message to pass the lint-commits? |
yes please |
kylo252
changed the title
`LvimToggleFormatOnSave` can disable the format-on-save feature properly, but once the feature is disabled from the enabled state, this command cannot enable it again. This is because `vim.api.nvim_get_autocmds` returns an empty list after disabling the feature. This commit checks the size of the returned autocmd list when `M.toolge_format_on_save` is called and enables the feature if the size is 0.
|
@kylo252 Revised the commit message and force-pushed. Could you please approve to run CI? |
|
Thanks! |
danielo515
pushed a commit
to danielo515/LunarVim
that referenced
this pull request
Jun 12, 2022
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Jun 12, 2022
* upstream/master: chore: update changelog chore: bump plugins version (LunarVim#2654) fix(autocmds): toggle format-on-save properly (LunarVim#2659) fix(nvimtree): update nvim-tree setup (LunarVim#2681) fix(log): add date to the timestamp of logs (LunarVim#2669) feat(cmp): add option to disable friendly-snippets (LunarVim#2660) feat: prompt when closing modified/term buffers (LunarVim#2658)
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Jun 12, 2022
* upstream/rolling: feat(which-key): added search command for colour highlights (LunarVim#2693) fix: skip calling nvim-tree.setup() more than once (LunarVim#2707) chore: bump plugins version (LunarVim#2654) fix(autocmds): toggle format-on-save properly (LunarVim#2659) fix(nvimtree): update nvim-tree setup (LunarVim#2681) fix(log): add date to the timestamp of logs (LunarVim#2669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LvimToggleFormatOnSavecan disable the format-on-save feature properly, but once the feature is disabled from the enabled state, this command cannot enable it again. This is becausevim.api.nvim_get_autocmdsreturns an empty list after disabling the feature.This commit checks the size of the returned autocmd list when
M.toggle_format_on_saveis called and enables the feature if the size is 0.How Has This Been Tested?
Run
LvimToggleFormatOnSaveseveral times, and confirm that the code is automatically formatted after runningLvimToggleFormatOnSavefrom the disabled state.