feat(which-key): added search command for colour highlights #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikiVanousek
approved these changes
Jun 6, 2022
|
@kylo252 are you able to merge this? What do you think about it? |
kylo252
reviewed
Jun 10, 2022
|
Done!
El vie., 10 jun. 2022 13:13, kylo252 ***@***.***> escribió:
… ***@***.**** commented on this pull request.
Sorry for the delay!
just a small modification, but otherwise LGTM! 🚀
------------------------------
In lua/lvim/core/which-key.lua
<#2693 (comment)>:
> @@ -244,6 +244,7 @@ M.config = function()
c = { "<cmd>Telescope colorscheme<cr>", "Colorscheme" },
f = { "<cmd>Telescope find_files<cr>", "Find File" },
h = { "<cmd>Telescope help_tags<cr>", "Find Help" },
+ H = { "<cmd>Telescope highlights<cr>", "Find color highlights" },
⬇️ Suggested change
- H = { "<cmd>Telescope highlights<cr>", "Find color highlights" },
+ H = { "<cmd>Telescope highlights<cr>", "Find highlight groups" },
—
Reply to this email directly, view it on GitHub
<#2693 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARKJWOQGG4EPEA5RXML2D3VOMPNXANCNFSM5X6G7DAA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
please rebase on latest rolling, it should solve the issues with the CI. |
Co-authored-by: kylo252 <59826753+kylo252@users.noreply.github.com>
|
@kylo252 done!
|
kylo252
approved these changes
Jun 12, 2022
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Jun 12, 2022
* upstream/rolling: feat(which-key): added search command for colour highlights (LunarVim#2693) fix: skip calling nvim-tree.setup() more than once (LunarVim#2707) chore: bump plugins version (LunarVim#2654) fix(autocmds): toggle format-on-save properly (LunarVim#2659) fix(nvimtree): update nvim-tree setup (LunarVim#2681) fix(log): add date to the timestamp of logs (LunarVim#2669)
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Jul 1, 2022
* upstream/master: fix(installer): use full path to verify_plugins.lua (LunarVim#2755) chore: update changelog feat(installer): add verify-plugins hook (LunarVim#2751) fix(lualine): unique buf client names (LunarVim#2683) chore(lsp): notify format request failed once when there is no client (LunarVim#2697) feat: fix a couple of issues (LunarVim#2750) chore: bump plugins version (LunarVim#2699) feat(which-key): added search command for colour highlights (LunarVim#2693) fix: skip calling nvim-tree.setup() more than once (LunarVim#2707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new search section on the default which key config to search for colour highlights.
This is a builtin telescope feature, so no new dependencies were added.
I think this is a cool addition because it enhances the discoverability of something that is not that commonly exposed
to vim users, and will help a lot in customising the theme to the users likings.
How Has This Been Tested?
<leader>sHThis is how it looks like
