Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cmp)!: adapt new recommendations #2913

Merged
merged 5 commits into from Aug 29, 2022
Merged

refactor(cmp)!: adapt new recommendations #2913

merged 5 commits into from Aug 29, 2022

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Aug 13, 2022

Description

  • adapt new recommendations
  • add <c-y> as an alternative confirm binding (should play better with autopairs and luasnip)
  • add <up> and <down> bindings for selecting completions
  • minor cleanup to method.jumpable

fixes #2876

@kylo252 kylo252 marked this pull request as ready for review August 21, 2022 15:16
@lvimuser
Copy link
Collaborator

What about #2083, I guess it should be optional? Does it conflict with commit_characters (which seems to be one of the reasons for the PR)?

/**
* An optional set of characters that when pressed while this completion is
* active will accept it first and then type that character.
*/

lua/lvim/core/cmp.lua Outdated Show resolved Hide resolved
@kylo252 kylo252 merged commit 9fcb6bb into rolling Aug 29, 2022
@kylo252 kylo252 deleted the cmp-refactor branch August 29, 2022 11:54
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Sep 14, 2022
* upstream/rolling:
  fix(plugins): handle deprecated options (LunarVim#3014)
  fix(core/autocmds): do not check for existence on clear_augroup (LunarVim#2963)
  fix(cmp): fix cmp select on CR (LunarVim#2980)
  fix(plugins): bring back original folke repos (LunarVim#2992)
  chore: bump plugins version (LunarVim#2972)
  fix(cmp): do not mutate the original confirm_opts on CR (LunarVim#2979)
  docs(lsp): fix the way of removing items from skipped_servers (LunarVim#2887)
  chore: remove unnecessary code (LunarVim#2923)
  chore: bump plugins version (LunarVim#2925)
  fix(ts_context_commentstring): block comment match new api (LunarVim#2948)
  fix(lsp): pass name arg to should_auto_install (LunarVim#2958)
  refactor(cmp)!: adapt new recommendations (LunarVim#2913)
  fix: update key bindings for comment.nvim to use new api (LunarVim#2926)
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Sep 14, 2022
* upstream/master: (30 commits)
  fix(plugins): handle deprecated options (LunarVim#3014)
  fix(core/autocmds): do not check for existence on clear_augroup (LunarVim#2963)
  fix(cmp): fix cmp select on CR (LunarVim#2980)
  fix(plugins): bring back original folke repos (LunarVim#2992)
  chore: bump plugins version (LunarVim#2972)
  fix(cmp): do not mutate the original confirm_opts on CR (LunarVim#2979)
  docs(lsp): fix the way of removing items from skipped_servers (LunarVim#2887)
  chore: remove unnecessary code (LunarVim#2923)
  chore: update changelog
  chore: bump plugins version (LunarVim#2925)
  fix(ts_context_commentstring): block comment match new api (LunarVim#2948)
  fix(lsp): pass name arg to should_auto_install (LunarVim#2958)
  refactor(cmp)!: adapt new recommendations (LunarVim#2913)
  fix: update key bindings for comment.nvim to use new api (LunarVim#2926)
  chore: bump plugins version (LunarVim#2895)
  feat(installer): handle INSTALL_PREFIX not on PATH (LunarVim#2912)
  docs: fix automatic_servers_installation example (LunarVim#2918)
  docs: fix some typos and enhance readability (LunarVim#2917)
  fix(statusline): display null-ls linters properly (LunarVim#2921)
  docs(windows): update example config (LunarVim#2919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete removes closing brackets!
4 participants