Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): pass name arg to should_auto_install #2958

Merged
merged 1 commit into from Aug 29, 2022

Conversation

danielo515
Copy link
Contributor

Description

The predicate function of the lsp manager should accept one argument to make it more clear and portable

How Has This Been Tested?

  • It is just a minor style correction

Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kylo252 kylo252 changed the title fix: the predicate function of auto install should take an argument fix(lsp): pass name arg to should_auto_install Aug 29, 2022
@kylo252 kylo252 merged commit 537a192 into LunarVim:rolling Aug 29, 2022
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Sep 14, 2022
* upstream/rolling:
  fix(plugins): handle deprecated options (LunarVim#3014)
  fix(core/autocmds): do not check for existence on clear_augroup (LunarVim#2963)
  fix(cmp): fix cmp select on CR (LunarVim#2980)
  fix(plugins): bring back original folke repos (LunarVim#2992)
  chore: bump plugins version (LunarVim#2972)
  fix(cmp): do not mutate the original confirm_opts on CR (LunarVim#2979)
  docs(lsp): fix the way of removing items from skipped_servers (LunarVim#2887)
  chore: remove unnecessary code (LunarVim#2923)
  chore: bump plugins version (LunarVim#2925)
  fix(ts_context_commentstring): block comment match new api (LunarVim#2948)
  fix(lsp): pass name arg to should_auto_install (LunarVim#2958)
  refactor(cmp)!: adapt new recommendations (LunarVim#2913)
  fix: update key bindings for comment.nvim to use new api (LunarVim#2926)
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Sep 14, 2022
* upstream/master: (30 commits)
  fix(plugins): handle deprecated options (LunarVim#3014)
  fix(core/autocmds): do not check for existence on clear_augroup (LunarVim#2963)
  fix(cmp): fix cmp select on CR (LunarVim#2980)
  fix(plugins): bring back original folke repos (LunarVim#2992)
  chore: bump plugins version (LunarVim#2972)
  fix(cmp): do not mutate the original confirm_opts on CR (LunarVim#2979)
  docs(lsp): fix the way of removing items from skipped_servers (LunarVim#2887)
  chore: remove unnecessary code (LunarVim#2923)
  chore: update changelog
  chore: bump plugins version (LunarVim#2925)
  fix(ts_context_commentstring): block comment match new api (LunarVim#2948)
  fix(lsp): pass name arg to should_auto_install (LunarVim#2958)
  refactor(cmp)!: adapt new recommendations (LunarVim#2913)
  fix: update key bindings for comment.nvim to use new api (LunarVim#2926)
  chore: bump plugins version (LunarVim#2895)
  feat(installer): handle INSTALL_PREFIX not on PATH (LunarVim#2912)
  docs: fix automatic_servers_installation example (LunarVim#2918)
  docs: fix some typos and enhance readability (LunarVim#2917)
  fix(statusline): display null-ls linters properly (LunarVim#2921)
  docs(windows): update example config (LunarVim#2919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants