fix(cmp): do not mutate the original confirm_opts on CR #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Sep 14, 2022
* upstream/rolling: fix(plugins): handle deprecated options (LunarVim#3014) fix(core/autocmds): do not check for existence on clear_augroup (LunarVim#2963) fix(cmp): fix cmp select on CR (LunarVim#2980) fix(plugins): bring back original folke repos (LunarVim#2992) chore: bump plugins version (LunarVim#2972) fix(cmp): do not mutate the original confirm_opts on CR (LunarVim#2979) docs(lsp): fix the way of removing items from skipped_servers (LunarVim#2887) chore: remove unnecessary code (LunarVim#2923) chore: bump plugins version (LunarVim#2925) fix(ts_context_commentstring): block comment match new api (LunarVim#2948) fix(lsp): pass name arg to should_auto_install (LunarVim#2958) refactor(cmp)!: adapt new recommendations (LunarVim#2913) fix: update key bindings for comment.nvim to use new api (LunarVim#2926)
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Sep 14, 2022
* upstream/master: (30 commits) fix(plugins): handle deprecated options (LunarVim#3014) fix(core/autocmds): do not check for existence on clear_augroup (LunarVim#2963) fix(cmp): fix cmp select on CR (LunarVim#2980) fix(plugins): bring back original folke repos (LunarVim#2992) chore: bump plugins version (LunarVim#2972) fix(cmp): do not mutate the original confirm_opts on CR (LunarVim#2979) docs(lsp): fix the way of removing items from skipped_servers (LunarVim#2887) chore: remove unnecessary code (LunarVim#2923) chore: update changelog chore: bump plugins version (LunarVim#2925) fix(ts_context_commentstring): block comment match new api (LunarVim#2948) fix(lsp): pass name arg to should_auto_install (LunarVim#2958) refactor(cmp)!: adapt new recommendations (LunarVim#2913) fix: update key bindings for comment.nvim to use new api (LunarVim#2926) chore: bump plugins version (LunarVim#2895) feat(installer): handle INSTALL_PREFIX not on PATH (LunarVim#2912) docs: fix automatic_servers_installation example (LunarVim#2918) docs: fix some typos and enhance readability (LunarVim#2917) fix(statusline): display null-ls linters properly (LunarVim#2921) docs(windows): update example config (LunarVim#2919) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CR mapping of cmp overrides the provided confirm_opts, making this change permanent. This PR avoids that.
How Has This Been Tested?