fix(lsp): enforce lvim completion for lua-server

[kylo252]

Description

lua-dev has changed the way it accepts settings, this will now hopefully accommodate those changes!

• fix lvim. auto-completion in config.lua
• add a select list of plugins by default that should always have auto-completion

  plugins = { "plenary.nvim", "telescope.nvim", "nvim-treesitter", "packer.nvim", "LuaSnip" }

fixes #3002

How Has This Been Tested?

• open config.lua start typing lvim.builtin.telescope.
• open config.lua start typing require'packer.

[lvimuser]

I suppose passing on_new_config in opts doesn't work?
Alternatively, lua_dev.setup() returns the settings, so we could try return vim.tbl_deep_extend("force", luadev, opts)

[kylo252]

I suppose passing on_new_config in opts doesn't work?

that one is getting overwritten unfortunately, I nearly want to write our own lua_dev.setup() and skip this entire dance..

[lvimuser]

Alternatively, lua_dev.setup() returns the settings, so we could try return vim.tbl_deep_extend("force", luadev, opts)

It seems that nlspsettings overrides the configuration in that case (not sure if it's a bug / intended or something else going on). So that might not work either...

[abzcoding]

@kylo252 I just removed my custom config and used this instead, and it worked just fine,
not sure about customization though

[abzcoding]

Also, I'm not sure if we need all of those plugins activated or not

 { "plenary.nvim", "telescope.nvim", "nvim-treesitter", "packer.nvim", "LuaSnip" }

it seems a bit much

[lvimuser]

Agree with abz. I don't think plenary should be a default either...
Maybe leave it empty for now?

[kylo252]

Edit: it was the packer pattern messing things up, it should've been packer.nvim, instead it was adding all the plugins 😅

---

it seems a bit much

I did change the maxPreload=1000, and it was pretty fast, but I have only tested on a single machine

Agree with abz. I don't think plenary should be a default either...
Maybe leave it empty for now?

the way I think about it is that you'd want these kind of completion for a nice dev environment:

• plenary: async, busted, curl, etc
• telescope: custom finders
• luasnip: snippets API
• treesitter: extended API that's not yet available in core
• packer: alternative async impl (probably not that useful)

I'll try to see if I can get the lua server to ignore test{s} directories, and how much would that save us.

[abzcoding]

thanks @kylo252, it is much faster now

LGTM 🚀

[lvimuser]

I did change the maxPreload=1000, and it was pretty fast, but I have only tested on a single machine

I missed that, looks pretty good!